Opened 17 years ago
Closed 17 years ago
#166 closed enhancement (fixed)
Safer migration script
| Reported by: | Peter Kovacs | Owned by: | Peter Kovacs | 
|---|---|---|---|
| Priority: | major | Milestone: | LEMON 1.1 release | 
| Component: | core | Version: | hg main | 
| Keywords: | Cc: | ||
| Revision id: | 
Description
Maybe we should have a safer migration script (rename script).
The current one in [560e4b6d020d] replaces all occurrences of graph, edge etc. whether it is a whole word or not. Thus it replaces graphic by digraphic, wedge by warc etc. It is not a huge problem for us, but since this script became a tool for users too, I prefer to make it (at least a little bit) safer.
Attachments (4)
Change History (10)
comment:1 Changed 17 years ago by
| Type: | defect → enhancement | 
|---|
Changed 17 years ago by
| Attachment: | 76af530ed2fe.patch added | 
|---|
comment:2 Changed 17 years ago by
| Owner: | changed from Alpar Juttner to Peter Kovacs | 
|---|---|
| Status: | new → assigned | 
Changed 17 years ago by
| Attachment: | 956a29f30887.patch added | 
|---|
comment:3 Changed 17 years ago by
[956a29f30887] contains a slightly improved variant of [76af530ed2fe].
comment:4 Changed 17 years ago by
| Resolution: | → fixed | 
|---|---|
| Status: | assigned → closed | 
[956a29f30887] went to the main branch.
comment:5 follow-up: 6 Changed 17 years ago by
| Resolution: | fixed | 
|---|---|
| Status: | closed → reopened | 
[74ed2aeefc5d] contains more improvements to the script to handle "(U)GRAPH_TYPEDEFS" and "directed graph/edge" patterns.
[236b1902e5cc] is an extended variant of [74ed2aeefc5d], in which (U)GRAPH_TYPEDEFS(typename ...) is renamed to TEMPLATE_(DI)GRAPH_TYPEDEFS(...).
Which one is better? Should we make such "smart" replacements to get better/nicer 1.x codes, or we should make only simple renamings?
Changed 17 years ago by
| Attachment: | migr1_74ed2aeefc5d.patch added | 
|---|
Changed 17 years ago by
| Attachment: | migr2_236b1902e5cc.patch added | 
|---|
comment:6 Changed 17 years ago by
| Resolution: | → fixed | 
|---|---|
| Status: | reopened → closed | 



[76af530ed2fe] makes the script safer and also improves the migration guide.
E.g. applying the new script to the following lines
the result is