Opened 16 years ago
Closed 16 years ago
#229 closed defect (fixed)
Default implemention of Tolerace<> is faulty
Reported by: | Alpar Juttner | Owned by: | Alpar Juttner |
---|---|---|---|
Priority: | major | Milestone: | LEMON 1.1 release |
Component: | core | Version: | release branch 1.0 |
Keywords: | Cc: | ||
Revision id: |
Description
The default implementation of Tolerance<> is faulty (it answers false
to everything). Probably, it should not exist at all except the documentation.
Attachments (1)
Change History (5)
comment:1 Changed 16 years ago by
Status: | new → assigned |
---|
Changed 16 years ago by
Attachment: | tolerance-int.patch added |
---|
comment:2 Changed 16 years ago by
The attached tolerance-int.patch implements the second approach. You can apply it on the top of deba's patch at ticket:230 without the --exact
hg option.
comment:3 follow-up: 4 Changed 16 years ago by
It seems much better than the former code.
I only found a small mistake in the doc. You wrote "otherwise it a specialized version must be ...", here "it" should be removed.
comment:4 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Replying to kpeter:
It seems much better than the former code.
I only found a small mistake in the doc. You wrote "otherwise it a specialized version must be ...", here "it" should be removed.
It's fixed and went to both the 1.0 and the main branches, see [7d7d9debb29a].
Replying to alpar:
So, we have two choices here:
Which one do you prefer?