Opened 16 years ago
Closed 16 years ago
#280 closed defect (fixed)
lemon/config.h gets distributed in the tarball
| Reported by: | Akos Ladanyi | Owned by: | Akos Ladanyi |
|---|---|---|---|
| Priority: | major | Milestone: | LEMON 1.1 release |
| Component: | build system | Version: | hg main |
| Keywords: | Cc: | ||
| Revision id: |
Description
lemon/config.h should be generated on the target system, and not distributed in the tarball.
Attachments (1)
Change History (9)
Changed 16 years ago by
| Attachment: | config-h-nodist.patch added |
|---|
comment:2 follow-up: 3 Changed 16 years ago by
This patch reverts the changes of [d8ca76573eb3] in Makefile.am, so that changeset wasn't good enough. Am I right?
comment:3 follow-up: 4 Changed 16 years ago by
Replying to kpeter:
This patch reverts the changes of [d8ca76573eb3] in Makefile.am, so that changeset wasn't good enough. Am I right?
Yes. The problem was that [d8ca76573eb3] caused lemon/config.h to be installed and distributed too.
comment:4 Changed 16 years ago by
Replying to ladanyi:
Replying to kpeter:
This patch reverts the changes of [d8ca76573eb3] in Makefile.am, so that changeset wasn't good enough. Am I right?
Yes. The problem was that [d8ca76573eb3] caused lemon/config.h to be installed and distributed too.
Which may cause problem in rare situations, i.e. when you
- make external build and
- apply certain extra configure option like
--with-coin=.
I don't do regular test for these situations together, that's why this problem remained hidden.
comment:5 follow-up: 6 Changed 16 years ago by
Shouldn't this be merged into both the main and to 1.0 branches?
comment:6 follow-up: 7 Changed 16 years ago by
comment:7 Changed 16 years ago by
Replying to ladanyi:
Replying to alpar:
Shouldn't this be merged into both the main and to 1.0 branches?
Yes, it should.
Done, see [32fb28fc9d42]. It also fixes a stupid mistake in 'lemon/core.h'.
comment:8 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
e90b4df7a035