#417 closed enhancement (fixed)
Greatly improved implementation of CostScaling
Reported by: | Peter Kovacs | Owned by: | Peter Kovacs |
---|---|---|---|
Priority: | major | Milestone: | LEMON 1.3 release |
Component: | core | Version: | hg main |
Keywords: | Cc: | ||
Revision id: |
Description
The attached changesets greatly improve the efficiency of CostScaling
algorithm. Moreover, a bug fix is also included.
Attachments (3)
Change History (11)
Changed 14 years ago by
Attachment: | 417-ca9d1dc77026--78d9eddfaf1a.patch added |
---|
Changed 14 years ago by
Attachment: | 417-ca9d1dc77026--78d9eddfaf1a.bundle added |
---|
comment:1 Changed 14 years ago by
Status: | new → assigned |
---|
comment:2 Changed 14 years ago by
These changes all together improve the overall performance of CostScaling by a factor of 1.5 on average (according to thorough benchmark tests).
comment:3 follow-up: 4 Changed 14 years ago by
The improvement is really impressive. Is there an up-to-date comparison of the min-cost flow algs in LEMON (an perhaps some comparison to other graph libs).
Also, shouldn't we backport the bugfix to version 1.2? Unfortunately I can't easily separate it from the other changes.
comment:4 Changed 14 years ago by
Replying to alpar:
The improvement is really impressive. Is there an up-to-date comparison of the min-cost flow algs in LEMON (an perhaps some comparison to other graph libs).
I will create such comparisons soon. And I'd like to write a paper about our implementations and these comparisons (in a few months).
Also, shouldn't we backport the bugfix to version 1.2? Unfortunately I can't easily separate it from the other changes.
I can easily create a simple patch that only fixes the bug. I will attach it soon, but these changesets could be kept for the main branch.
Changed 14 years ago by
Attachment: | 417-bugfix-only-f112c18bc304.patch added |
---|
comment:5 Changed 14 years ago by
I attached the simple bug fix [f112c18bc304]. This bug fix can be merged into branch 1.2, and maybe to the main branch, as well. But note that the previous changesets also contain these modifications along with other improvements (see [4866b640dba9]) that fixes the issue independently (and makes the algorithm faster in AUGMENT mode).
comment:6 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
The bug fix [f112c18bc304] has been merged into branches 1.2 and the main. All the remaining changes has been merged into the main branch as [fe283caf6414], [6ea176638264], [ddd3c0d3d9bf], [1226290a9b7d] and [a07b6b27fe69].
comment:8 Changed 13 years ago by
Type: | defect → enhancement |
---|
I attached 5 changesets (both in a patch file and in a bundle file):