Opened 18 years ago
Closed 17 years ago
#65 closed task (fixed)
Port the Euler tour algorithm
| Reported by: | Alpar Juttner | Owned by: | Alpar Juttner |
|---|---|---|---|
| Priority: | critical | Milestone: | LEMON 1.1 release |
| Component: | core | Version: | |
| Keywords: | Cc: | ||
| Revision id: |
Description
It affects the file:
- lemon/euler.h
Attachments (1)
Change History (15)
comment:1 Changed 18 years ago by
| Milestone: | LEMON 1.0 release → Post 1.0 |
|---|
comment:2 Changed 17 years ago by
| Owner: | changed from Alpar Juttner to Peter Kovacs |
|---|---|
| Status: | new → assigned |
comment:3 Changed 17 years ago by
comment:4 Changed 17 years ago by
comment:5 Changed 17 years ago by
| Owner: | changed from Peter Kovacs to Alpar Juttner |
|---|---|
| Status: | assigned → new |
comment:6 Changed 17 years ago by
| Status: | new → assigned |
|---|
comment:7 Changed 17 years ago by
| Priority: | major → critical |
|---|
Changed 17 years ago by
| Attachment: | euler-port-6b493b6d9328-1f3e7fb1edf2-f5eaf04b41c5.bundle added |
|---|
comment:8 follow-up: 9 Changed 17 years ago by
The attached bundle file contains the port of the Euler walk related stuff.
Could you please review it?
comment:9 follow-up: 10 Changed 17 years ago by
Replying to alpar:
The attached bundle file contains the port of the Euler walk related stuff.
Could you please review it?
Is there any pending issue with this port?
comment:10 follow-up: 11 Changed 17 years ago by
Replying to alpar:
Replying to alpar:
The attached bundle file contains the port of the Euler walk related stuff.
Could you please review it?
Is there any pending issue with this port?
I have some minor issues:
- the todo should be removed from the file (it has already test)
- the documentation must be fixed (UEulerIt is already removed)
- the header does not have include guard
- the copyright date should be updated
- unfortunately, the connectivity.h is not in the Makefile.am, which should be fixed before
- euler.h should include directly the adaptors.h
- test main() should return 0
After the fixes it could be push to the main.
comment:11 follow-up: 12 Changed 17 years ago by
Replying to deba:
- euler.h should include directly the adaptors.h
Oops, this revealed another bug - adaptors.h needs lemon/bits/graph_extender.h to be included. What would be the right place to do that?
- Should it be included directly by
adaptors.h? - Or by
lemon/bits/graph_adaptor_extender.h?
comment:12 Changed 17 years ago by
Replying to alpar:
Replying to deba:
- euler.h should include directly the adaptors.h
Oops, this revealed another bug -
adaptors.hneedslemon/bits/graph_extender.hto be included. What would be the right place to do that?
- Should it be included directly by
adaptors.h?- Or by
lemon/bits/graph_adaptor_extender.h?
Use the first option (direct inclusion).
comment:13 Changed 17 years ago by
Replying to alpar:
Oops, this revealed another bug -
adaptors.hneedslemon/bits/graph_extender.hto be included. What would be the right place to do that?
- Should it be included directly by
adaptors.h?- Or by
lemon/bits/graph_adaptor_extender.h?
As far as I see adaptors.h doesn't need bits/graph_extender.h, only bits/map_extender.h. And bits/graph_adaptor_extender.h doesn't need any of these files, so I suggest to put an #include <lemon/bits/map_extender.h> only into adaptors.h. It should be enough.
comment:14 Changed 17 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
This port is in the main branch, see [42d4b889903a], [3af83b6be1df] and [22f932bbb305].
Iron decorates your home. They have a wide variety of design, assuring that you will find a special one for display at home. The metal stai http://www.hebei-railings.cn/