Opened 16 years ago
Closed 16 years ago
#97 closed enhancement (fixed)
Reorganize fundamental header files and those of minor gadgets.
| Reported by: | Alpar Juttner | Owned by: | Peter Kovacs |
|---|---|---|---|
| Priority: | major | Milestone: | LEMON 1.0 release |
| Component: | core | Version: | hg main |
| Keywords: | Cc: | ||
| Revision id: |
Description (last modified by )
Currently, the following files are affected.
lemon/maps.hlemon/graph_utils.hlemon/assert.hlemon/error.hlemon/tolerance.hlemon/assert.hlemon/bits/invalid.hlemon/bits/traits.hlemon/bits/utility.h
Attachments (5)
Change History (20)
comment:1 Changed 16 years ago by
| Version: | → hg main |
|---|
comment:2 Changed 16 years ago by
| Description: | modified (diff) |
|---|---|
| Summary: | Reorganize header files of minor gadgets. → Reorganize fundamental header files and those of minor gadgets. |
comment:3 Changed 16 years ago by
| Owner: | changed from Alpar Juttner to Balazs Dezso |
|---|
Changed 16 years ago by
| Attachment: | 89e004f571d9.patch added |
|---|
comment:4 follow-up: 5 Changed 16 years ago by
| Status: | new → assigned |
|---|
comment:5 Changed 16 years ago by
Replying to deba:
The [89e004f571d9] patch makes the reorganization.
The patch seems to be broken, I cannot import it with --exact.
Changed 16 years ago by
| Attachment: | 5b8f6f06687e.patch added |
|---|
comment:6 follow-up: 7 Changed 16 years ago by
The previous patch was damaged, I have uploaded a new patch [5b8f6f06687e].
comment:7 follow-up: 8 Changed 16 years ago by
Replying to deba:
The previous patch was damaged, I have uploaded a new patch [5b8f6f06687e].
make check fails on [5b8f6f06687e]
Changed 16 years ago by
| Attachment: | 219172956e81.patch added |
|---|
comment:8 follow-up: 9 Changed 16 years ago by
Replying to alpar:
Replying to deba:
The previous patch was damaged, I have uploaded a new patch [5b8f6f06687e].
make check fails on [5b8f6f06687e]
The [219172956e81] fixes the problem. The invalid.h is forgotten in my repository, therefore the make check did not show the bug for me. Now, the make distcheck compiles well.
comment:9 follow-up: 10 Changed 16 years ago by
Replying to deba:
The [219172956e81] fixes the problem.
It indeed fixes some problem, but not all. The make check still fails.
Changed 16 years ago by
| Attachment: | a5d8c039f218.patch added |
|---|
comment:10 follow-up: 11 Changed 16 years ago by
Replying to alpar:
Replying to deba:
The [219172956e81] fixes the problem.
It indeed fixes some problem, but not all. The make check still fails.
The related problem was in the demo files, which was not enabled in repository. Now, I hope [a5d8c039f218] is correct.
comment:11 follow-ups: 12 13 Changed 16 years ago by
Replying to deba:
The related problem was in the demo files, which was not enabled in repository. Now, I hope [a5d8c039f218] is correct.
Yes now it compiles fine. I like these changes, too. Still I would like to hear other's opinion.
I think, we need a short description at the doc of core.h saying that these file are automatically included by the graphs (make sure that it is indeed done so), therefore the users do not have to include this header directly.
After that we can close the ticket.
comment:12 Changed 16 years ago by
Replying to alpar:
Yes now it compiles fine. I like these changes, too. Still I would like to hear other's opinion.
I also like these changes. It seems to be simplier and more rational. It is good that no include file is needed for e.g. copying graphs apart form the graph type that is used. And maps can also be founded more easily.
Test files shouldn't be reorganized? It seems to be strange to have graph_utils_test.cc if do not have graph_utils.h any more.
comment:13 follow-up: 14 Changed 16 years ago by
| Owner: | changed from Balazs Dezso to Peter Kovacs |
|---|---|
| Status: | assigned → new |
Replying to alpar:
I think, we need a short description at the doc of core.h saying that these file are automatically included by the graphs (make sure that it is indeed done so), therefore the users do not have to include this header directly.
Peter, could you do this doc improvements?
Changed 16 years ago by
| Attachment: | aebc0161f6e5.patch added |
|---|
comment:14 follow-up: 15 Changed 16 years ago by
comment:15 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Replying to kpeter:
Replying to alpar:
Peter, could you do this doc improvements?
See [aebc0161f6e5].
Many thanks.
The [89e004f571d9] patch makes the reorganization.