Opened 16 years ago
Closed 16 years ago
#99 closed task (fixed)
Revise check() macro
| Reported by: | Peter Kovacs | Owned by: | Alpar Juttner |
|---|---|---|---|
| Priority: | major | Milestone: | LEMON 1.0 release |
| Component: | core | Version: | hg main |
| Keywords: | Cc: | ||
| Revision id: |
Description (last modified by )
test/test_tools.h contains
- the
check()macro, which is used in all test files, and - some tools about Petersen (sub)graphs.
I suggest separating the widely used check() macro and the Petersen tools, e.g. put the macro into a assert.h.
Shouldn't we use LEMON_ASSERT instead of check() or shouldn't check() be an alias for it?
Change History (5)
comment:1 Changed 16 years ago by
| Description: | modified (diff) |
|---|
comment:2 follow-up: 3 Changed 16 years ago by
comment:3 follow-up: 4 Changed 16 years ago by
Replying to alpar:
No, because
check()should never be switched off.
OK.
I think the graph related specific tools should be moved from test_tools.h to (di)graph_test.h and maybe only the check() macro should be in test_tools.h.
comment:4 follow-up: 5 Changed 16 years ago by
Replying to kpeter:
I think the graph related specific tools should be moved from
test_tools.hto(di)graph_test.hand maybe only thecheck()macro should be intest_tools.h.
It is done in [02f4d5d9bfd7]. Now test_tools.h contains only the check() macro.
Is it okay or should it be moved to assert.h?
comment:5 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Replying to kpeter:
It is done in [02f4d5d9bfd7]. Now
test_tools.hcontains only thecheck()macro.
Is it okay or should it be moved toassert.h?
No it shouldn't. The current situation is perfect.
No, because
check()should never be switched off.