#131 closed enhancement (fixed)
Add section writer for lgf tools
Reported by: | Balazs Dezso | Owned by: | Balazs Dezso |
---|---|---|---|
Priority: | major | Milestone: | LEMON 1.0 release |
Component: | core | Version: | hg main |
Keywords: | Cc: | ||
Revision id: |
Description
The lgf section writer is implemented in [5b77a093fd62] patch.
Attachments (2)
Change History (7)
Changed 16 years ago by
Attachment: | 5b77a093fd62.patch added |
---|
comment:1 Changed 16 years ago by
Version: | → hg main |
---|
comment:2 follow-up: 3 Changed 16 years ago by
Changed 16 years ago by
Attachment: | 8fada33fc60a.patch added |
---|
comment:3 follow-up: 4 Changed 16 years ago by
Replying to alpar:
Replying to deba:
The lgf section writer is implemented in [5b77a093fd62] patch.
In [5b77a093fd62],
sectionLines()
takes astd::string
reference where it puts the output line and it has abool
return value for indicating that there is no more lines. (What about the last execution ofsectionLines()
will the returnedstd::string
written to the output file?)I would prefer a callback function with no parameter and an
std::string
return value, where the empty string would indicate that the section is finished.What do you think of this?
The patch [8fada33fc60a] contains the reworked section writer which follows your suggestion.
Btw, I found a couple of typos is the doc.
I tried to correct the documentation, I hope there are less typos than before.
comment:4 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Replying to deba:
The patch [8fada33fc60a] contains the reworked section writer which follows your suggestion
It is now in the main branch.
comment:5 Changed 16 years ago by
Type: | defect → enhancement |
---|
Replying to deba:
In [5b77a093fd62],
sectionLines()
takes astd::string
reference where it puts the output line and it has abool
return value for indicating that there is no more lines. (What about the last execution ofsectionLines()
will the returnedstd::string
written to the output file?)I would prefer a callback function with no parameter and an
std::string
return value, where the empty string would indicate that the section is finished.What do you think of this?
Btw, I found a couple of typos is the doc.