Opened 15 years ago
Closed 15 years ago
#321 closed defect (fixed)
Inconsistency - (di)graphCopy vs copyPath
| Reported by: | Peter Kovacs | Owned by: | Peter Kovacs |
|---|---|---|---|
| Priority: | critical | Milestone: | LEMON 1.2 release |
| Component: | core | Version: | hg main |
| Keywords: | Cc: | ||
| Revision id: |
Description
There is an annoying inconsistency in the current releases (1.0, 1.1): we have functions graphCopy() and copyPath(). Moreover the order of their parameters also differ: graphCopy(from, to) and copyPath(to, from).
More than one year ago, we decided to modify the 0.x version of graph copying functions: copyGraph(to, from) --> graphCopy(from, to), see #150. However, we were not careful enoguh, the path copying tools should have been modified, as well.
What could/should we do with this problem after we have released these tools with inconsistent interfaces?
Attachments (1)
Change History (5)
comment:1 follow-up: 2 Changed 15 years ago by
| Status: | new → assigned |
|---|
comment:2 Changed 15 years ago by
gReplying to kpeter:
We could introduce
pathCopy(from, to)and keepcopyPath(to, from)as an obsolete solution without showing it in the doc (just for backward compatibility).
I agree. We may even leave it in the doc with a proper remark that it is deprecated.
Changed 15 years ago by
| Attachment: | 321-c6acc34f98dc.patch added |
|---|
comment:3 Changed 15 years ago by
[c6acc34f98dc] solves this problem as you suggested.
It is in the top of the bug fix [41bdb4d6c8c3], thus you can merge it into all branches you want.
comment:4 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
The patch went to all branches.
We could introduce
pathCopy(from, to)and keepcopyPath(to, from)as an obsolete solution without showing it in the doc (just for backward compatibility).